ISPN-6417 Remove replication queue support #4161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to wait for a confirmation from CI. |
danberindei
force-pushed
the
ISPN-6417_remove-replication-queue
branch
from
ac7be83
to
aabd858
Compare
* Remove replication queue attributes from XSD/parser * Remove the entire AsyncConfiguration class * Remove the replication queue thread pool in the XSD/parser * Keep the thread pool as deprecated in the programmatic config
danberindei
force-pushed
the
ISPN-6417_remove-replication-queue
branch
from
aabd858
to
d7dfd4e
Compare
| @@ -545,6 +543,7 @@ datagrid-infinispan.leveldb-store.remove=Removes a cache leveldb store configura | |||
| datagrid-infinispan.leveldb-store.block-size=The cache store block size | |||
| datagrid-infinispan.leveldb-store.cache-size=Cache size for the cache store | |||
| datagrid-infinispan.leveldb-store.clear-threshold=Cache store cache clear threshold | |||
| datagrid-infinispan.expiration.queue-size=Leveldb store expiration queue size | |||
There was a problem hiding this comment.
@tristantarrant The LevelDB expiration queue-size attribute was "reusing" the datagrid-infinispan.clustered-cache.queue-size description, and datagrid-infinispan.leveldb-store.expiration.queue-size didn't work. Could you have a look and maybe create a separate JIRA?
|
Pushed to master, thanks @danberindei |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replication queue thread pool wasn't deprecated in 8.2, so I've only deprecated it.
I've removed the
AsyncConfigurationcompletely, and deprecatedSyncConfiguration.replTimeout(replaced withClusteringConfiguration.remoteTimeout) so thatSyncConfigurationcan be removed in 10.0.https://issues.jboss.org/browse/ISPN-6417
https://issues.jboss.org/browse/ISPN-6423