ISPN-6436 Overriding the name of an indexed property is not supported with DSL query #4226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anistor
force-pushed
the
t_6436_m
branch
28 times, most recently
from
1d3ab41
to
0073db2
Compare
anistor
changed the title
|
There are some familiar commits in this PR, should it be rebased on master instead? |
|
I'll rebase. I thought I already did that... |
|
Not sure why github.com UI shows more commits. Should be only 2. Pls fetch again. |
|
Now it looks ok. Only 2 commits. |
anistor
force-pushed
the
t_6436_m
branch
2 times, most recently
from
ca42286
to
a86b236
Compare
| //todo validate params | ||
| for (String paramName : getParameterNames()) { | ||
| if (namedParameters.get(paramName) == null) { | ||
| throw new IllegalArgumentException("Query parameter '" + paramName + "' was not set"); |
There was a problem hiding this comment.
Probably we need some internationalization here.
|
Only some small picky issues. Otherwise looks ok to me. |
|
Fixed all. |
anistor
force-pushed
the
t_6436_m
branch
3 times, most recently
from
cf129ab
to
352e351
Compare
|
Rebased. |
|
pulling |
|
merged, thanks @anistor ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-6436
https://issues.jboss.org/browse/ISPN-6508