ISPN-6545 Avoid leaking HR server req details #4266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,7 +51,7 @@ public NettyTransport getTransport() { | |||
| } | |||
|
|
|||
| void resetNow() { | |||
| decodeCtx.resetParams(); | |||
There was a problem hiding this comment.
We may as well remove this method while we are at it.
|
Changes are fine with me, but these are also the ones I suggested. If anyone wants to comment please do otherwise I will integrated tomorrow. |
|
Changes looks good, but is the node.js client the only way to reproduce it? |
|
@gustavonalle unfortunately yes. It only affected an async client, where it was sending multiple requests on the same socket. |
|
@gustavonalle We'd need an async Java client to replicate indeed. |
|
@wburns Updated |
|
Pulling.. |
|
Integrated into master, thanks @galderz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-6545