ISPN-6550 Remote iterator does not work in compatibility mode #4271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 26, 2016 18:37
…en compat is enabled
| @@ -98,7 +98,7 @@ class DefaultIterationManager(val cacheManager: EmbeddedCacheManager) extends It | |||
| }) | |||
|
|
|||
| val segmentListener = new IterationSegmentsListener | |||
| val compatInfo = CompatInfo(cacheManager.getCacheConfiguration(cacheName).compatibility()) | |||
| val compatInfo = CompatInfo(cacheManager.getCache(cacheName).getCacheConfiguration.compatibility()) | |||
There was a problem hiding this comment.
For some reason cacheManager.getCacheConfiguration(cacheName).compatibility() returns the wrong cache configuration (from the default one) instead of the cacheName's cache configuration.
This needs more investigation (another JIRA)
There was a problem hiding this comment.
Possibly related https://issues.jboss.org/browse/ISPN-6577
|
Looks good to me.. |
|
Pushing to master, but the backport will need another PR as there are compilation issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-6550