ISPN-6748: Deprecate Singleton Mode for Persistent Stores. #4398
Conversation
|
@ryanemerson 46 new failures, they look related to the changes, can you please have a look? Thx :) |
|
@galderz I will take another look at this when I return from PTO. |
|
@galderz I have fixed the problems from before. The current test failures don't seem related to my changes (Hotrod). |
|
There are still some tests failing: http://ci.infinispan.org/viewLog.html?buildId=40575&buildTypeId=bt9&guest=1 Retriggering CI. |
| @@ -11,6 +11,11 @@ | |||
| import org.infinispan.commons.configuration.attributes.AttributeSet; | |||
| import org.infinispan.configuration.global.GlobalConfiguration; | |||
|
|
|||
| /** | |||
| * @deprecated Singleton writers will be removed in 9.1. If it is desirable that all nodes don't write to the underlying store | |||
There was a problem hiding this comment.
If we deprecate them in 9.0, we probably won't be able to remove them until 10... Am I right @tristantarrant ?
|
The code looks fine (let's have another look at those CI failures as soon as TeamCity rebuilds this PR). The only concern that I have is removing it in |
|
I agree with @slaskawi , removal won't happen until 10 |
|
@slaskawi @tristantarrant Version updated to 10.0. The hotrod test is still failing, it seems it is related to these changes. |
|
@slaskawi @tristantarrant The issues with the tests were resolved with a pull --rebase. This should be good to merge. |
|
Integrated, thanks Ryan! |
https://issues.jboss.org/browse/ISPN-6748