ISPN-6893 Scala removal from server/core module #4449
Conversation
|
The code looks really good... awesome amount of work! Just a heads up - it will collide with Muti-tenancy PR: #4348 but hopefully not that much. Also those test failures seem to be related. |
| } | ||
|
|
||
| private ClientAuth requireClientAuth(SslConfiguration sslConfig) { | ||
| return sslConfig.enabled() ? ClientAuth.REQUIRE : ClientAuth.NONE; |
There was a problem hiding this comment.
This should be sslConfig.requireClientAuth() ;)
TL;DR
After turning on SSL Debug it turned out that server challenges client for certificate (which was not associated with the client keystore). This suggested that either client cert file is wrong or server challenge is wrong. I was lucky with the latter :)
There was a problem hiding this comment.
Aha, thanks :) - I figured it was in NettyChannelInitializer somewhere, not sure how I didn't see this one. Thanks!
wburns
force-pushed
the
scala_removal
branch
2 times, most recently
from
7c50a49
to
50130f1
Compare
|
I am trying to leave the commits separated by module so it is easier to track the changes. I will be adding JIRAs for them today. |
wburns
changed the title
|
Ready for review/integration. |
| public abstract class AbstractProtocolServer<A extends ProtocolServerConfiguration> extends AbstractCacheIgnoreAware | ||
| implements ProtocolServer<A> { | ||
|
|
||
| private final JavaLog log = LogFactory.getLog(getClass(), JavaLog.class); |
There was a problem hiding this comment.
Any reason not to rename "JavaLog" to just "Log" like in all other modules ?
There was a problem hiding this comment.
That was the name before, I can change it.
| import java.util.Set; | ||
|
|
||
| /** | ||
| * @author gustavonalle |
There was a problem hiding this comment.
Could you please add something meaningful to this javadoc?
|
Awesome work! Some small, really picky stuff found. |
|
Looks good! Bye bye scala 😢 😉 Needs rebasing though. |
|
Rebased, will fix up others. |
|
Updated, just wait for a test run to verify nothing is broken before integrating. |
|
Pulling ! |
|
Pushed, thanks |
No description provided.