ISPN-6856 Testsuite: replace inheritance with @Factory #4456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In MultipleCacheManagerTest, factory method can be automatized with @InCacheMode and @InTransactionMode * Other common settings that require combination of parameters (lockingMode, isolationMode, totalOrder) can be set in overridden factory method * For filtering single test, there are options -Dtest.infinispan.xxx * Further customization possible through @TestSelector annotation * Downside: IntelliJ does not report test name with parameters but just appends (1), (2) etc. You can see the parameters from the failing test name, though.
* AbstractInfinispanTest uses @Before/AfterClass to setup tracked resources (to wrap each instance of test), inheriting classes have to follow
|
+1,259 −2,305 Looks particularly good ! |
|
Pushed to master. This is my extra commit: 5be2758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My motivation is since I am adding a new cache mode that could reuse many of the tests (with minor modifications), I would duplicate the classes. Adding a one-liner into factory method, or just an annotation is better.