ISPN-6868 Expose extra configuration for the SSLContext protocol in t… #4462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he Hot Rod client
| @@ -24,12 +24,21 @@ | |||
| */ | |||
| public class SslContextFactory { | |||
| private static final Log log = LogFactory.getLog(SslContextFactory.class); | |||
| public static final String DEFAULT_SSL_PROTOCOL = "TLS"; | |||
There was a problem hiding this comment.
I think it would be best to increase this to TLSv1.2
There was a problem hiding this comment.
Sure, I was with Java 1.6 in my mind when creating this PR 😄
|
@tristantarrant fixed |
|
The code looks good to me but could you please mention somewhere in the docs what it does and when to use it? Just a few words... |
|
I have pushed it already, so the docs will need to be in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he Hot Rod client
https://issues.jboss.org/browse/ISPN-6868