ISPN-6927 Remove acquireRemoteLock and gtx from ClusteredGetCommand #4494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Deprecated | ||
| default ClusteredGetCommand buildClusteredGetCommand(Object key, long flagsBitSet, boolean acquireRemoteLock, GlobalTransaction gtx) { | ||
| if (acquireRemoteLock) throw new UnsupportedOperationException(); |
There was a problem hiding this comment.
Could you please add some information to the exception?
|
Rebased and added exception message. |
|
LGTM |
slaskawi
approved these changes
Sep 15, 2016
|
Integrated thanks! SHA1: |
danberindei
reviewed
Sep 16, 2016
| @@ -60,8 +61,8 @@ public MarshalledEntry load(Object key) throws PersistenceException { | |||
| if (!isCacheReady()) return null; | |||
|
|
|||
| ClusteredGetCommand clusteredGetCommand = new ClusteredGetCommand( | |||
| key, cacheName, EnumUtil.EMPTY_BIT_SET, false, null, | |||
| cache.getCacheConfiguration().dataContainer().keyEquivalence()); | |||
| key, cacheName, EnumUtil.bitSetOf(Flag.SKIP_OWNERSHIP_CHECK), | |||
There was a problem hiding this comment.
Seems like a change that got in from the scattered cache (there I use SKIP_OWNERSHIP_CHECK more extensively as it has better meaning than just CACHE_MODE_LOCAL). It is unintentional within a scope of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-6927