[8.2.x ] ISPN-4390 Realigned with ConcurrentHashMap from the JSR-166 repository #4560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danberindei @wburns I've put the changes on this PR for 8.2.x only. I've factored out the inner classes as requested on the other PR, which I've closed |
slaskawi
suggested changes
Oct 6, 2016
| package org.infinispan.commons.util.concurrent.jdk8backported; | ||
|
|
||
| /** | ||
| * @author Will Burns |
There was a problem hiding this comment.
Do we consider this as a public API? If so, could you please add some Javadoc (or remove it completely if we don't).
There was a problem hiding this comment.
None of the classes in this package are considered public API
There was a problem hiding this comment.
So maybe the javadocs should be simply removed... an empty thing is just rubbish...
| package org.infinispan.commons.util.concurrent.jdk8backported; | ||
|
|
||
| /** | ||
| * @author Will Burns |
|
|
||
| import java.util.Map; | ||
|
|
||
| /** |
| import java.util.Collection; | ||
|
|
||
| /** | ||
| * // TODO: Document this |
| package org.infinispan.commons.util.concurrent.jdk8backported; | ||
|
|
||
| /** | ||
| * @author Will Burns |
- jsr166/src/jdk8/java/util/concurrent/ConcurrentHashMap.java 1.3 - factor out all inner classes/interfaces from BECHMV8 - refactor access to the Unsafe instace - extract the package-level logic from ThreadLocalRandom
tristantarrant
force-pushed
the
ISPN-4390-8.2.x/jsr166
branch
from
a9403c2
to
eeadb5c
Compare
|
@slaskawi I've removed all the pointless javadocs |
|
LGTM, integrating |
|
Integrated, thanks Tristan! BTW - I updated fix versions for https://issues.jboss.org/browse/ISPN-4390 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-4390