ISPN-7183 Upgrade to protostream-4.0.0.Alpha2 #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are test failures: ProtobufMetadataManagerInterceptorTest |
anistor
commented
Nov 10, 2016
|
|
||
| /** | ||
| * All fields of Protobuf types are indexed and stored by default. This behaviour is usually acceptable in most cases | ||
| * but it can become a performance problem if there are many or very large fields. To avoid such problems Infinispan allows you |
There was a problem hiding this comment.
This doc needs to be revised. I'm on it!
|
@gustavonalle This PR is a single commit extracted from a larger PR that is also coming soon. I might have not extracted all the changes, hence the test failures. Will fix ASAP. |
* adapt to the protostream configuration API changes * update protostream marshaller for the new Transaction.longDescription property in the test domain model * add protostream annotations for analyzer * rename protostream annotation @IndexedField to @field and enhance it with more capabilities similar to Hibernate Search
anistor
changed the title
|
It seems I've introduced a bug in protostream. I'll release Alpha2 to fix that today. |
|
Should be fixed now. |
|
integrated, thanks |
|
@anistor Unfortunatelly the failures are still on master: http://ci.infinispan.org/viewLog.html?buildId=44478&tab=buildResultsDiv&buildTypeId=Infinispan_MasterHotspotJdk8&guest=1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@IndexedFieldto@Fieldand enhance it with more capabilities similar to Hibernate Searchhttps://issues.jboss.org/browse/ISPN-7183