ISPN-7199 BaseEmbeddedQuery must ensure the ClosableIterator is closed #4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anistor
force-pushed
the
t_close_iterator_m
branch
from
e271612
to
3195438
Compare
danberindei
suggested changes
Nov 15, 2016
| Comparator<Comparable[]> comparator = getComparator(); | ||
| if (comparator == null) { | ||
| // collect unsorted results and get the requested page if any was specified | ||
| if (iterator.hasNext()) { |
There was a problem hiding this comment.
There's already one iterator.hasNext() check above.
anistor
force-pushed
the
t_close_iterator_m
branch
from
3195438
to
c78de74
Compare
danberindei
approved these changes
Nov 15, 2016
|
Integrated, thanks Adrian! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-7199