ISPN-7290 Document Data Container Changes #4731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .`MANUAL` | ||
| This eviction strategy is identical to NONE, in that it disables automatic eviction altogether, but signals the intention that the user wants to evict entries manually. The effect is to disable misleading warning validation messages. | ||
| Eviction is handled by link:https://github.com/ben-manes/caffeine[Caffeine] utilizing | ||
| the TinyLFU with an additional admission window. This was chosen as provides high hit |
There was a problem hiding this comment.
/TinyLFU/TinyLFU algorithm/
| ==== Storage type | ||
|
|
||
| Infinispan allows the user to configure in what form their data is stored. Each | ||
| form supports the same features of Infinispan, however evicttion can be limited |
| provides, they are: | ||
|
|
||
| .`OBJECT` | ||
| Stores the keys and values as is provided from the user. Only `COUNT` eviction |
There was a problem hiding this comment.
Stores the keys and values as objects.
I would mention that this means on-heap
| type is supported. | ||
|
|
||
| .`BINARY` | ||
| Stores the keys and values as a byte[] under the scenes. Both `COUNT` and |
There was a problem hiding this comment.
Mention that the marshaller will be used to transform the keys/values to/from byte[]
Also mention that on-heap memory will be used
tristantarrant
requested changes
Dec 16, 2016
|
|
||
| .`OFF-HEAP` | ||
| Stores the keys and values in native memory outside of the | ||
| perview of the Garbage Collector as a byte[]. Both `COUNT` and |
|
|
||
| In case there is an eviction element, this table describes behaviour of eviction | ||
| In case there is an memory element, this table describes behaviour of eviction |
* Changed eviction section to have data container * Added in caffeine and off heap
|
Fixed the comments, thanks @tristantarrant ! |
galderz
reviewed
Dec 19, 2016
| provides, they are: | ||
|
|
||
| .`OBJECT` | ||
| Stores the keys and values as objects in the Java heap Only `COUNT` eviction |
tristantarrant
approved these changes
Dec 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-7290