ISPN-7530 InfinispanStoreRocksDBIT leaves files in the current directory #4902
Conversation
| </property> | ||
| <!-- To debug the Arquillian managed application server: --> | ||
| <!-- property name="javaVmArguments">-Xrunjdwp:transport=dt_socket,address=8000,server=y,suspend=y -Xmx512m -Dorg.jboss.remoting-jmx.timeout=300 -Djava.net.preferIPv4Stack=true -Djgroups.bind_addr=127.0.0.1</property--> | ||
| <!--<property name="javaVmArguments">-Xrunjdwp:transport=dt_socket,address=8000,server=n,suspend=y -Dorg.jboss.remoting-jmx.timeout=300--> | ||
| <!-- -Djboss.socket.binding.port-offset=100 -Xmx512m -Djava.net.preferIPv4Stack=true--> |
There was a problem hiding this comment.
Changes in this file could be probably removed.
There was a problem hiding this comment.
I really want to keep this in because the existing commented javaVmArguments were incomplete, and it was frustrating when I enabled debugging and the test wouldn't run.
There was a problem hiding this comment.
In that case, could you please add a comment with those switches at the beginning of the file? Let's now throw rubbish all around :D
There was a problem hiding this comment.
@slaskawi I could remove the comment altogether, but I would definitely not leave the comment as it was before...
| builder.persistence() | ||
| .addStore(RocksDBStoreConfigurationBuilder.class) | ||
| .location(tmpDirectory) | ||
| .expiredLocation(tmpDirectory + "-expired"); |
There was a problem hiding this comment.
I'm confused... shouldn't we use expireDir instead?
There was a problem hiding this comment.
I think RocksDB needs both those directories (but I might be wrong). Maybe @tristantarrant would know.
There was a problem hiding this comment.
ok but here you are using
tmpDirectory(this.getClass()) + "-expired"
and in the beginning you are creating
private static String expiredDir = tmpDirectory(InfinispanStoreRocksDBIT.class) + File.separator + "rocksdb-expiredtestcache";
danberindei
force-pushed
the
ISPN-7530_InfinispanStoreRocksDBIT_cleanup
branch
from
3d5e190
to
3ab4b24
Compare
|
Updated to fix |
danberindei
force-pushed
the
ISPN-7530_InfinispanStoreRocksDBIT_cleanup
branch
2 times, most recently
from
75c04ec
to
646b08b
Compare
danberindei
force-pushed
the
ISPN-7530_InfinispanStoreRocksDBIT_cleanup
branch
from
646b08b
to
bcc5778
Compare
| </property> | ||
| <!-- To debug the Arquillian managed application server: --> | ||
| <!-- property name="javaVmArguments">-Xrunjdwp:transport=dt_socket,address=8000,server=y,suspend=y -Xmx512m -Dorg.jboss.remoting-jmx.timeout=300 -Djava.net.preferIPv4Stack=true -Djgroups.bind_addr=127.0.0.1</property--> | ||
| <!--<property name="javaVmArguments">-Xrunjdwp:transport=dt_socket,address=8000,server=n,suspend=y -Dorg.jboss.remoting-jmx.timeout=300--> | ||
| <!-- -Djboss.socket.binding.port-offset=100 -Xmx512m -Djava.net.preferIPv4Stack=true--> |
There was a problem hiding this comment.
In that case, could you please add a comment with those switches at the beginning of the file? Let's now throw rubbish all around :D
| builder.persistence() | ||
| .addStore(RocksDBStoreConfigurationBuilder.class) | ||
| .location(tmpDirectory) | ||
| .expiredLocation(tmpDirectory + "-expired"); |
There was a problem hiding this comment.
I think RocksDB needs both those directories (but I might be wrong). Maybe @tristantarrant would know.
danberindei
force-pushed
the
ISPN-7530_InfinispanStoreRocksDBIT_cleanup
branch
2 times, most recently
from
dd278d7
to
65c485e
Compare
|
@danberindei and @slaskawi 👍 looks good to me. |
danberindei
force-pushed
the
ISPN-7530_InfinispanStoreRocksDBIT_cleanup
branch
from
65c485e
to
f88ed8e
Compare
danberindei
force-pushed
the
ISPN-7530_InfinispanStoreRocksDBIT_cleanup
branch
from
f88ed8e
to
a93972a
Compare
https://issues.jboss.org/browse/ISPN-7530