Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-7532 Do not log configuration warnings for templates #4907

Merged
merged 1 commit into from Mar 2, 2017
Merged

ISPN-7532 Do not log configuration warnings for templates #4907

merged 1 commit into from Mar 2, 2017

Conversation

tristantarrant
Copy link
Member

  • Do not log configuration warnings for templates
  • Also extract some configuration exceptions to log
  • Do not disable expiration reaper in server

https://issues.jboss.org/browse/ISPN-7532

@tristantarrant tristantarrant added this to the 9.0.0.Final milestone Feb 27, 2017
@tristantarrant tristantarrant changed the title ISPN-7352 Do not log configuration warnings for templates ISPN-7532 Do not log configuration warnings for templates Feb 27, 2017
danberindei
danberindei reviewed Feb 27, 2017
View reviewed changes
core/src/main/java/org/infinispan/util/logging/Log.java Outdated
CacheConfigurationException unsupportedAsyncCacheMode(CacheMode cacheModed);
CacheConfigurationException unsupportedAsyncCacheMode(CacheMode cacheMode);

@Message("Invalid cache loader configuration for '%s'. If a cache loader is configured as a singleton, the cache loader cannot be shared in a cluster!", id = 442)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing value=.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems I can omit it only if it's the only attribute

@tristantarrant
Copy link
Member Author

Fixed it

@danberindei
Copy link
Member

Seeing test failures now:

testNegativeTimeout(org.infinispan.xsite.XSiteStateTransferFileParsingTest)  Time elapsed: 0.022 sec  <<< FAILURE!
org.testng.TestException: 
The exception was thrown with the wrong message: expected "Timeout must be higher or equals than 1 \(one\)." but got "ISPN000449: XSite state transfer timeout must be higher or equals than 1 (one)."

@tristantarrant
ISPN-7532 Do not log configuration warnings for templates
da12327 
- Also extract some configuration exceptions to log
- Do not disable expiration reaper in server
@tristantarrant tristantarrant force-pushed the ISPN-7532/no_warnings_templates branch from 6f017cc to da12327 Compare March 1, 2017 07:23
@tristantarrant
Copy link
Member Author

Fixed the test.

@ryanemerson ryanemerson merged commit 772bea7 into infinispan:master Mar 2, 2017
@tristantarrant tristantarrant deleted the ISPN-7532/no_warnings_templates branch August 3, 2017 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danberindei danberindei danberindei left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.0.Final
3 participants
@tristantarrant @danberindei @ryanemerson