Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-7070 #4914

Merged
merged 1 commit into from Feb 28, 2017
Merged

ISPN-7070 #4914

merged 1 commit into from Feb 28, 2017

Conversation

wburns
Copy link
Member

@wburns wburns commented Feb 27, 2017

CacheNotifierImplInitialTransferDistTest.testIterationBeganAndSegmentNotComplete
random failures

  • Make sure reads into listener collection are also synchronized
  • Remove listener before replacing notifier that it registered with

https://issues.jboss.org/browse/ISPN-7070

CacheNotifierImplInitialTransferDistTest.testIterationBeganAndSegmentNotComplete
random failures

* Make sure reads into listener collection are also synchronized
* Remove listener before replacing notifier that it registered with
@wburns
Copy link
Member Author

wburns commented Feb 27, 2017

I can't confirm 100% that this fixes it, but it seems the issue could have been caused by an unsynchronized read causing it not to see the updated collection size variable.

@pruivo
Copy link
Member

pruivo commented Feb 28, 2017

I've run it locally for 1h and it didn't fail .I'm going to integrate it and see if it fails again in the future.

@pruivo pruivo merged commit f219434 into infinispan:master Feb 28, 2017
@wburns
Copy link
Member Author

wburns commented Mar 8, 2017

The log seems similar to the previous one. Everything seems fine with the notifications. I will add a log message to the listener so we can see exactly which event is not being counted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants