Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-7135 #4915

Merged
merged 1 commit into from Feb 28, 2017
Merged

ISPN-7135 #4915

merged 1 commit into from Feb 28, 2017

Conversation

wburns
Copy link
Member

@wburns wburns commented Feb 27, 2017

ClusterListenerReplTest.testPrimaryOwnerGoesDownBeforeBackupRaisesEvent
random failures

  • Change test to allow for 2 retries

https://issues.jboss.org/browse/ISPN-7135

Copy link
Member

@pruivo pruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@@ -122,10 +114,13 @@ public void testPrimaryOwnerGoesDownAfterBackupRaisesEvent() throws InterruptedE
String returnValue = future.get(10, TimeUnit.SECONDS);
assertEquals(FIRST_VALUE, returnValue);

assertEquals(2, clusterListener.events.size());
assertTrue(clusterListener.events.size() >= 2);
sassertTrue(clusterListener.events.size() <= 3);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sassertdoesn't exist :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍 Intellij does when I press ctrl-s but ctrl wasn't held down long enough :)

ClusterListenerReplTest.testPrimaryOwnerGoesDownBeforeBackupRaisesEvent
random failures

* Change test to allow for 2 retries
@wburns
Copy link
Member Author

wburns commented Feb 28, 2017

Fixed

@pruivo pruivo merged commit 4b005c4 into infinispan:master Feb 28, 2017
@pruivo
Copy link
Member

pruivo commented Feb 28, 2017

integrated! thanks @wburns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants