Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-7627 Add test to verify off heap and binary storage work with #4984

Merged
merged 1 commit into from Mar 17, 2017
Merged

ISPN-7627 Add test to verify off heap and binary storage work with #4984

merged 1 commit into from Mar 17, 2017

Conversation

wburns
Copy link
Member

@wburns wburns commented Mar 15, 2017

indexing

  • Added BINARY and OFF_HEAP indexed tests
  • Fixed issue with putAll with BINARY and OFF_HEAP

https://issues.jboss.org/browse/ISPN-7627

@wburns wburns added this to the 9.0.0.Final milestone Mar 15, 2017
@gustavocoding
Copy link

@wburns There are failing query tests

@wburns
Copy link
Member Author

wburns commented Mar 16, 2017

Looking..

@wburns
Copy link
Member Author

wburns commented Mar 16, 2017

Yeah from the command line it runs the tests in parallel and causes issues, have to look into how to tweak it. Looks like the Factory annotation isn't working as I would have hoped 👎

@wburns
Copy link
Member Author

wburns commented Mar 16, 2017

Removed Factory annotation as it shouldn't be needed for ClusteredCacheTest

@wburns
Copy link
Member Author

wburns commented Mar 16, 2017

Tests pass now http://ci.infinispan.org/viewLog.html?buildId=52617&buildTypeId=bt9

@wburns
Copy link
Member Author

wburns commented Mar 16, 2017

Let me double check the usage of factory with the subclasses.

@wburns
Copy link
Member Author

wburns commented Mar 16, 2017

Okay it is fine since the class doesn't have the factory method, the subclass does :) [1] So this is all good.

[1] https://github.com/infinispan/infinispan/blob/master/core/src/test/java/org/infinispan/test/MultipleCacheManagersTest.java#L437

@wburns
ISPN-7627 Add test to verify off heap and binary storage work with
ba7fe88 
indexing

* Added BINARY and OFF_HEAP indexed tests
* Fixed issue with putAll with BINARY and OFF_HEAP
@gustavocoding gustavocoding merged commit f2e116f into infinispan:master Mar 17, 2017
@gustavocoding
Copy link

Merged, thanks @wburns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavocoding gustavocoding gustavocoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.0.Final
2 participants
@wburns @gustavocoding