ISPN-1315 - Reduce number of Logger instances being created #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sanne, do you have a 5.0.x branch? Not sure what's been agreed wrt porting fixes to the 5.0.x branch now that 5.0.0.final is out. |
|
wasn't sure we wanted this to be backported, but in case I've added one just now: ISPN-1315-5.0.x |
|
You might want to raise this on the dev list as well as I know from talking to David that there should be no need to make logger instances static with JBoss Logging 3 as the logger instances should be shared. |
|
raised on dev-list, still I think this commit is ready to be pushed: the forum user reported a good boot performance improvement (from 3 minutes to 10 seconds) |
|
Definitely push - I meant just to raise this to David's attention so he can comment, as I doubt he monitors pull requests ;-) |
|
Oops, hit wrong button! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-1315
see http://community.jboss.org/thread/170415?tstart=0
to know why I made this change.