ISPN-7002 Early detection of improper query module usage in wildfly #5000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anistor
force-pushed
the
t_7002_fail_fast_m
branch
2 times, most recently
from
46ef5d0
to
a578b8a
Compare
* If the query jar is added just as a pom dependency but not as a proper wildfly module dependency it allows the application classloading to apparently work but the query module is never initialised leading to future failures
anistor
force-pushed
the
t_7002_fail_fast_m
branch
from
a578b8a
to
37dd9db
Compare
|
Integrated in master and 8.2.x, thanks Adrian! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add early detection of the case when the query jar is added just as a pom dependency but not as a proper wildfly module dependency. This allows the application classloading to apparently work but the query module never gets initialised and leads to further failures.
PLEASE do not close the Jira yet.
https://issues.jboss.org/browse/ISPN-7002