ISPN-7650 Refactoring two functional test assertions #5003
Conversation
karesti
changed the title
| assert false : "Should have thrown a UnsupportedOperationException"; | ||
| } catch (UnsupportedOperationException uoe) { | ||
| } | ||
| col.add(newObj); |
There was a problem hiding this comment.
I think that you want to test adding to both keys and values - this will throw exception with keys and the values won't be tested.
IMO having Collection[] { keys, values } is a strange pattern; I would rather use keys.add(newObj); and values.add(newObj) separately.
Note that instead of try-catch or @Test(expectedExceptions = ...) you can also use Exceptions.expectException(...).
|
|
||
| assertOnAllCachesAndOwnership("k1", "value"); | ||
|
|
||
| assert !nonOwner.getAdvancedCache().getComponentRegistry().getComponent(DistributionManager.class).getCacheTopology().isWriteOwner("k1"); | ||
| assertFalse(nonOwner.getAdvancedCache().getComponentRegistry().getComponent(DistributionManager.class).getCacheTopology().isWriteOwner("k1")); |
There was a problem hiding this comment.
There's a helper method TestingUtil.extractComponent
|
@rvansa I modified both tests with your comments |
|
Integrated, thanks @karesti |
|
Oops, I have noticed only now that it uses TestNG assertions; eventually all codebase should use only the AssertJUnit ones (despite the annotations are TestNG). My fault, I should have pointed it out during the review earlier; it's not an issue, but @karesti in the future please use AssertJUnit. |
|
Yes, indeed I realised it just after too. No pb, I will refactor them on my branches to import the good ones if nobody does it before |
https://issues.jboss.org/browse/ISPN-7650