ISPN-7696 RemoveExpired could be called with updated value #5054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvansa
reviewed
Apr 12, 2017
| synchronized (e) { | ||
| long lifespan = e.getLifespan(); | ||
| if (ExpiryHelper.isExpiredMortal(lifespan, e.getCreated(), currentTimeMillis)) { | ||
| handleLifespanExpireEntry(e.getKey(), e.getValue(), lifespan, true); |
There was a problem hiding this comment.
You don't need to call this within the synchronized block.
There was a problem hiding this comment.
I am aware. I was being more lazy and to be honest it doesn't save very much as this lock is only on the entry. I can change it up though.
There was a problem hiding this comment.
And actually I also would need synchronization around the else if block, which is probably why I didn't separate it. Code will be come quite messy. I will see if I can clean it up more though.
|
Fixed. |
|
Great, let's integrate this. |
|
@wburns Integrated, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-7696