ISPN-7754 forEach method #5280
Closed
ISPN-7754 forEach method #5280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the default forEach method in a distributed way
rvansa
reviewed
Jul 17, 2017
| * to owning nodes to perform the operation in the most performant way. However this means the biconsumer must | ||
| * have an appropriate {@link org.infinispan.commons.marshall.Externalizer} or be {@link java.io.Serializable} itself. | ||
| * <p> | ||
| * For transactional caches, whenever the values of the caches are collections, and the mapping function modifies the collection, the collection |
There was a problem hiding this comment.
It's not specific to collections: the values in cache must not be mutated, period, and we'll rather enforce that than remove the limitation.
There was a problem hiding this comment.
Err, actually this is a consumer, and you should not modify the collection - what would you do with the copy?
There was a problem hiding this comment.
this is me that does copy/paste without thinking twice sometimes. So well, the comment is not correct, indeed !!
rvansa
reviewed
Jul 17, 2017
| * This limitation could disappear in following releases if technically possible. | ||
| */ | ||
| @Override | ||
| void forEach(BiConsumer<? super K, ? super V> action); |
There was a problem hiding this comment.
Where is the SerializableBiConsumer overload?
rvansa
reviewed
Jul 17, 2017
| @@ -357,6 +358,12 @@ public V compute(K key, BiFunction<? super K, ? super V, ? extends V> remappingF | |||
| } | |||
|
|
|||
| @Override | |||
| public void forEach(BiConsumer<? super K, ? super V> action) { | |||
| authzManager.checkPermission(subject, AuthorizationPermission.WRITE); | |||
rvansa
reviewed
Jul 17, 2017
| return offset; | ||
| } | ||
|
|
||
| public void testForEach() throws Exception { |
There was a problem hiding this comment.
This test is silly. Accessing a static variable on (potentially) remote node...
rvansa
requested changes
Jul 17, 2017
|
Temporarily closing because of CI overload |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-7754