ISPN-8174 LocalStreamIteratorWithPassivationTest random failures #5419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disabled test as we don't support concurrent activation with iteration
| @@ -113,7 +113,7 @@ public void testConcurrentActivation() throws InterruptedException, ExecutionExc | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| @Test(enabled = false, description = "This requires supporting concurrent activation in cache loader interceptor") | |||
There was a problem hiding this comment.
You are disabling a test as well as changing it ?
There was a problem hiding this comment.
This test didn't really test anything, hence why it was working most of the time :D
This test is supposed to test the filtering of the store to work while a concurrent activation occurs. We don't support concurrent activation with stores when doing iteration or state transfer. In those cases we will actually miss entries. This test was updated to more properly reflect that. Hence why it must now be disabled, since it doesn't work until we can finally fix the concurrent activation bug.
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-8174