Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-7741 POM comments redux #5445

Merged
merged 5 commits into from Sep 20, 2017
Merged

ISPN-7741 POM comments redux #5445

merged 5 commits into from Sep 20, 2017

Conversation

danberindei
Copy link
Member

https://issues.jboss.org/browse/ISPN-7741

  • Use lxml in the release script to really preserve comments and CDATA sections
  • Add a test script to run before the release and check for comment changes
  • Format POMs to minimize changes with the next release.

@tristantarrant
Copy link
Member

nice

@danberindei
Copy link
Member Author

Updated to use bin/reversion.sh to update the versions for the release and to fix the karaf-maven-plugin failures after the version change.

@tristantarrant tristantarrant merged commit 28b5d10 into infinispan:master Sep 20, 2017
@tristantarrant
Copy link
Member

Merged, thanks

@danberindei danberindei deleted the ISPN-7741_pom_comments_redux branch September 21, 2017 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@danberindei @tristantarrant