ISPN-8414 Colored testsuite progress

[tristantarrant]

https://issues.jboss.org/browse/ISPN-8414

[tristantarrant]

Need to find a way to suppress colors when running in CI

[danberindei]

I wonder if this is really necessary... jansi uses isatty to avoid writing the escape codes when output is redirected.

[danberindei]

Actually, I see that isatty check is in AnsiConsole, and you're not using it... still, when I run the build from my Python script (which uses Popen to parse the output and set the test count in the title), the colours just disappear.

[tristantarrant]

Checking isatty is pointless, since we use surefire's fork which filters the output. In fact System.console() returns null when running the testsuite.
Can I have your Python script so I can check ?

[danberindei]

@tristantarrant I forgot surefire is already doing one redirect... but that makes the fact that ./build.sh -pl commons | tee build.log doesn't show any colors on the terminal or escapes in the file even more confusing. Maybe it's zsh being extra helpful...

You could avoid the Jenkins-specific check by using -Dansi.strip, like AnsiConsole does. And to skip the H , in IDEs, you could check for -Dinfinispan.module-suffix.

[tristantarrant]

@danberindei I have made some changes:

• use -Djansi.strip (added to Jenkinsfile) to explicitly avoid colors
• if output has been not been redirected, print directly without the magic H , prefix

[danberindei]

Integrated, thanks Tristan!