ISPN-8517 Lazily ressurect ice fromMemory #5583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should cherry pick as is into 9.1.x as well. |
|
Test failure is unrelated. |
wburns
force-pushed
the
ISPN-8517_less_ice_offheap
branch
from
ff04a77
to
0e0ae79
Compare
|
Added in changes from #5567 |
wburns
force-pushed
the
ISPN-8517_less_ice_offheap
branch
2 times, most recently
from
97fb11e
to
d9574c6
Compare
|
Looks like CI failures were from the random tx failures in #5591. I have rebased and letting CI run again. |
danberindei
suggested changes
Nov 24, 2017
| @@ -359,6 +360,78 @@ public boolean equalsKey(long address, WrappedBytes wrappedBytes) { | |||
| return true; | |||
| } | |||
|
|
|||
| /** | |||
| * Returns whether entry is expired or not. | |||
| * @param address the address of the entry's key to check | |||
There was a problem hiding this comment.
Isn't it the address of the entry?
| @@ -359,6 +360,78 @@ public boolean equalsKey(long address, WrappedBytes wrappedBytes) { | |||
| return true; | |||
| } | |||
|
|
|||
| /** | |||
| * Returns whether entry is expired or not. | |||
| } | ||
|
|
||
| protected void afterCacheCreated(EmbeddedCacheManager cm) { | ||
|
|
||
| } | ||
|
|
||
| public void testSimpleExpirationLifespan() throws Exception { | ||
| public ExpirationFunctionalTest withStorage(StorageType storage) { |
| timeService.advance(2); | ||
|
|
||
| for (int i = 0; i < SIZE; i++) { | ||
| cache.getAdvancedCache().getDataContainer().executeTask(KeyFilter.ACCEPT_ALL_FILTER, (k, ice) -> { throw new RuntimeException("No task should be executed on expired entry"); }); |
There was a problem hiding this comment.
The lambda could be on its own line.
wburns
force-pushed
the
ISPN-8517_less_ice_offheap
branch
from
d9574c6
to
8dc23cf
Compare
wburns
force-pushed
the
ISPN-8517_less_ice_offheap
branch
from
8dc23cf
to
266329c
Compare
* Reuse address pointer for compute remove * Don't resurrect value if not needed
wburns
force-pushed
the
ISPN-8517_less_ice_offheap
branch
from
266329c
to
7c65215
Compare
wburns
force-pushed
the
ISPN-8517_less_ice_offheap
branch
from
7c65215
to
48c40e8
Compare
|
Okay this has been updated and also fixes the REST failures on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-8517
https://issues.jboss.org/browse/ISPN-8500
This issue now also includes objects that are expired are not read.