ISPN-8552 Reinstate infinispan depedencies to the bom #5603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure not related |
galderz
requested changes
Nov 27, 2017
bom/pom.xml
Outdated
| <version>${project.version}</version> | ||
| </dependency> | ||
|
|
||
| <!-- Infinispan aggregate jars --> |
There was a problem hiding this comment.
These are uber jars, please don't add these. They're not designed for users who use Maven. You can get all sorts of issues with them.
Even if they were there before, we definitely don't want them here.
ryanemerson
force-pushed
the
ISPN-8552
branch
from
c63452a
to
65df1c2
Compare
|
@galderz Removed |
ryanemerson
force-pushed
the
ISPN-8552
branch
from
65df1c2
to
eabd48f
Compare
|
@ryanemerson Looks good, integrating... |
galderz
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-8552