ISPN-8721 rearrange constructor to avoid race condition

[tomdearman]

rearrange constructor to avoid race condition leading to NPE in beginInvalidatingWithPFER

[ghost]

Can one of the admins verify this patch?

[rvansa]

Thanks for the fix. It would be even better if you could add a test-case as well.

[tomdearman]

I spent some time with trying to understand how to get NodeEnvironment test util class to work such that you could guarantee one fake environment starts up part way through whilst another already started tries to update its cache but I was unable to do that. I suppose now I know where the problem is maybe something could be done directly with the PutFromLoadValidator class to directly test it. But since it would still require that the constructor was partially completed, I am not sure how to go about that. Any examples of how that is done elsewhere to test a similar race condition in infinispan? Tom

…

On 25 Jan 2018, at 13:28, Radim Vansa ***@***.***> wrote: Thanks for the fix. It would be even better if you could add a test-case as well. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5698 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIYjkGOi74pvaB0NcL8UfCvS5PRxgcXvks5tOIFugaJpZM4Rsmtd>.

[galderz]

@rvansa I think it'd be hard to develop a unit test case for this, I think we should just integrate it.

[rvansa]

@galderz Will you file a PR against ORM 5.1/5.2?

[galderz]

@rvansa Fixed in cache-commons