Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-8720 Implement test for REST with SSL configuration template #5717

Merged
merged 1 commit into from Feb 26, 2018
Merged

ISPN-8720 Implement test for REST with SSL configuration template #5717

merged 1 commit into from Feb 26, 2018

Conversation

vjuranek
Copy link
Member

@vjuranek vjuranek commented Feb 1, 2018

galderz
galderz requested changes Feb 16, 2018
View reviewed changes
Copy link
Member

@galderz galderz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a question about the need of another container for this test.

server/integration/testsuite/src/test/resources/arquillian.xml
@@ -339,6 +339,20 @@
<property name="jmxDomain">${server.jmx.domain}</property>
</configuration>
</container>
<container qualifier="standalone-rest-ssl" mode="manual">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, do we really need a new container for this? Couldn't the hotrod-ssl container contain configuration to access rest over ssl? The more containers we have, the longer it takes to test :|

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no, this is a test for particular config template which we provide as part of ISPN distribution, i.e. each test in ExampleConfigsIT has to start its own container to test given template. We can either reduce number of templates we provide or skip testing of the templates (and especially later option I wouldn't recommend).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

@galderz galderz merged commit 3d2e0db into infinispan:master Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galderz galderz galderz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vjuranek @galderz