ISPN-8775 Encoder documentation #5738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavocoding
force-pushed
the
ISPN-8775/encoder-doc
branch
from
b68cfc7
to
9ffcfde
Compare
karesti
requested changes
Feb 13, 2018
| gis.close(); | ||
| return baos.toByteArray(); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Unable to compress", e); |
There was a problem hiding this comment.
Won't be better to have a custom runtime exception ?
There was a problem hiding this comment.
I didn't see that this is in test
| } | ||
| return result.toString(); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Unable to decompress", e); |
| public interface Encoder { | ||
|
|
||
| /** | ||
| * Convert data in the read/write format to the storage format. |
There was a problem hiding this comment.
is it necessary to include the javadoc here ?
karesti
approved these changes
Feb 13, 2018
| gis.close(); | ||
| return baos.toByteArray(); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Unable to compress", e); |
There was a problem hiding this comment.
I didn't see that this is in test
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-8775