New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search update, ORM update, fixing the built modules #5766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Sanne, much appreciated. However, org.infinispan.query.blackbox.CompatModeClusteredCacheTest.testMerge
seems related
wildfly-modules/pom.xml
Outdated
<plugin> | ||
<groupId>org.wildfly.build</groupId> | ||
<artifactId>wildfly-server-provisioning-maven-plugin</artifactId> | ||
<version>1.2.6.Final</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, but could you uitlise the ${version.org.wildfly.build-tools}
property? It's currently on version 1.2.3.Final
but I can't imagine bumping this to 1.2.6.Final
causing any issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I missed that this wasn't the first use.
I'll use the property as you suggest, and add a separate ticket to update it (which I include in this PR)
That's an existing issue, I noticed the same but found it on ci.infinispan.org so I created a ticket for it yesterday: https://issues.jboss.org/browse/ISPN-8837? |
@ryanemerson updated the PR. |
…earch feature pack
…ldFly Provisioning
…version in the parent pom
<dependency> | ||
<groupId>org.jboss.marshalling</groupId> | ||
<artifactId>jboss-marshalling-osgi</artifactId> | ||
</dependency> | ||
<!-- Deps for the lucene module, will eventually be replaced by https://github.com/hibernate/lucene-modules --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the time has finally come :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes, a good step forward 👍
Running another CI, as it seems not all commits were tested.... |
They actually were, my bad, integrating... |
thanks @Sanne ! |
Sending a more thourough explanation of this proposal to the mailing list.