Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search update, ORM update, fixing the built modules #5766

Merged
merged 6 commits into from Feb 20, 2018

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Feb 19, 2018

Sending a more thourough explanation of this proposal to the mailing list.

Copy link
Contributor

@ryanemerson ryanemerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sanne, much appreciated. However, org.infinispan.query.blackbox.CompatModeClusteredCacheTest.testMerge seems related

<plugin>
<groupId>org.wildfly.build</groupId>
<artifactId>wildfly-server-provisioning-maven-plugin</artifactId>
<version>1.2.6.Final</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but could you uitlise the ${version.org.wildfly.build-tools} property? It's currently on version 1.2.3.Final but I can't imagine bumping this to 1.2.6.Final causing any issues.

Copy link
Member Author

@Sanne Sanne Feb 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I missed that this wasn't the first use.
I'll use the property as you suggest, and add a separate ticket to update it (which I include in this PR)

@Sanne
Copy link
Member Author

Sanne commented Feb 19, 2018

However, org.infinispan.query.blackbox.CompatModeClusteredCacheTest.testMerge seems related

That's an existing issue, I noticed the same but found it on ci.infinispan.org so I created a ticket for it yesterday: https://issues.jboss.org/browse/ISPN-8837?

@Sanne
Copy link
Member Author

Sanne commented Feb 19, 2018

@ryanemerson updated the PR.

<dependency>
<groupId>org.jboss.marshalling</groupId>
<artifactId>jboss-marshalling-osgi</artifactId>
</dependency>
<!-- Deps for the lucene module, will eventually be replaced by https://github.com/hibernate/lucene-modules -->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the time has finally come :)

Copy link

@gustavocoding gustavocoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes, a good step forward 👍

@gustavocoding
Copy link

Running another CI, as it seems not all commits were tested....

@gustavocoding
Copy link

They actually were, my bad, integrating...

@gustavocoding gustavocoding merged commit f181b46 into infinispan:master Feb 20, 2018
@gustavocoding
Copy link

thanks @Sanne !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants