Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-8930 RestOperationsTest random test failures #5828

Merged
merged 2 commits into from Mar 13, 2018
Merged

ISPN-8930 RestOperationsTest random test failures #5828

merged 2 commits into from Mar 13, 2018

Conversation

wburns
Copy link
Member

@wburns wburns commented Mar 9, 2018 •
edited

RestOperationsTest#shouldPutImmortalEntryWithZeroTtlAndIdleTime random
failure

  • Increased expiration times so they shouldn't expire with thread delay

https://issues.jboss.org/browse/ISPN-8930
https://issues.jboss.org/browse/ISPN-8934

@wburns wburns changed the title ISPN-8930 ISPN-8930 RestOperationsTest random test failures Mar 9, 2018
@wburns
ISPN-8930
0e89373 
RestOperationsTest#shouldPutImmortalEntryWithZeroTtlAndIdleTime random
failure

* Increased expiration times so they shouldn't expire with thread delay
* Also changed to clear data container which is faster for test
@wburns wburns force-pushed the ISPN-8930_rest_expiration_random_failure branch from 00c5a37 to 0e89373 Compare March 9, 2018 16:33
@wburns
Copy link
Member Author

wburns commented Mar 9, 2018

I also changed it to clear the data container instead of the cache. This is much faster for off heap making the test run in 1/4 of the time it used to for me.

@karesti
Copy link
Contributor

karesti commented Mar 12, 2018

@wburns RestOperationsTest did not fail on the build but the org.infinispan.rest.RestOperationsOffHeapTest. shouldPutImmortalEntryWithZeroTtlAndIdleTime
failed
org.junit.ComparisonFailure: expected:<[45190]L> but was:<[1859446]L>

karesti
karesti requested changes Mar 12, 2018
View reviewed changes
Copy link
Contributor

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other related tests seem to be failing now

@wburns
Copy link
Member Author

wburns commented Mar 12, 2018

Hrmm, I think this actually might have revealed a bug in off heap, I will have to look closer in a little bit.

@wburns
Copy link
Member Author

wburns commented Mar 12, 2018 •
edited

I have fixed up the mix up in off heap, hopefully no tests were relying on the wrong behavior :D

@wburns wburns added this to the 9.2.1.Final milestone Mar 12, 2018
@karesti karesti merged commit 635ab86 into infinispan:master Mar 13, 2018
@karesti
Copy link
Contributor

karesti commented Mar 13, 2018

integrated !!! thanks @wburns !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karesti karesti karesti requested changes

Assignees
No one assigned
Labels
Test fix Trivial :-)
Projects
None yet
Milestone
9.2.1.Final
2 participants
@wburns @karesti