ISPN-9013 Partition Handling enabled toggle should set merge-policy=NONE #5878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristantarrant
requested changes
Mar 28, 2018
| @@ -1591,7 +1591,7 @@ TimeoutException coordinatorTimeoutWaitingForView(int expectedViewId, int curren | |||
| IllegalStateException getConflictsStateTransferInProgress(String cacheName); | |||
|
|
|||
| @LogMessage(level = WARN) | |||
| @Message(value = "The partition handling 'enable' attribute has been deprecated. Please update your configuration file to use the 'type' attribute instead", id = 464) | |||
| @Message(value = "The partition handling 'enable' attribute has been deprecated. Please update your configuration to use 'when-split' instead", id = 464) | |||
Added deprecation javadoc and fix log message.
danberindei
force-pushed
the
ISPN-9013_partitionhandling_enabled
branch
from
624eae5
to
64b8fd5
Compare
|
Fixed @tristantarrant |
|
I am fine with the changes, but thinking about this more. If we are doing this for backwards compatibility shouldn't the default be |
|
I think we should have better defaults win over blind backwards compatibility. As long as a user can configure the old behaviour, I'm fine with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-9013
Added deprecation javadoc and fix log message.