Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-8911 Copy dependencies for the distribution only for specific modules #5879

Merged

Conversation

tristantarrant
Copy link
Member

@tristantarrant
Copy link
Member Author

Hints for testing: mvn -Pdistribution clean install
Then look at server/integration/target/distribution/infinispan-server-x.y.z-bin.zip: it should not contain a dependency directory.
Then look at distribution/target/distribution and examine the all and minimal distributions. Try to run the GUI demo and check that the lib directory contains dependencies for the supplied modules.

@ryanemerson
Copy link
Contributor

@tristantarrant The changes look good to me, however when I attempt to run the gui demo I get the following error: Error: Could not find or load main class org.infinispan.Version, however this also exists on the master branch. I have created https://issues.jboss.org/browse/ISPN-9055 to track the issue.

@ryanemerson ryanemerson merged commit 637f737 into infinispan:master Apr 10, 2018
@ryanemerson
Copy link
Contributor

Thanks @tristantarrant, the above error was not really an issue as you explained.

@tristantarrant tristantarrant deleted the ISPN-8911/redundant_dependencies branch January 21, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants