ISPN-8719 KeySet.(iterator|spliterator|stream) not compatible with #5896
Conversation
wburns
force-pushed
the
ISPN-8719_key_converter
branch
3 times, most recently
from
3133fca
to
eab7315
Compare
|
I have added tests and they all seem to work except for ProtocolVersion.2.3 where for some reason the result is getting jumbled and the messageId is found to be 0 causing a NPE. I am not sure where the bug is as the server side seems to be sending the correct bytes back. I need to look into it further still. |
|
So the cause with version 2.3 is due to the fact that the retrieveEntries in newer clients always uses the 2.5 protocol even when 2.3 is set. Also newer clients have never been able to communicate to any server of version 2.2 or older in general. So that means no client since 8.1 could ever talk to any version older than that. |
wburns
force-pushed
the
ISPN-8719_key_converter
branch
4 times, most recently
from
0844d07
to
ad864bb
Compare
|
Also fixed a 2.5+ client talking to 2.4 since it was always passing meta but that is not returned in 2.4. This would make reading entries return incorrect values and/or possibly hang. |
wburns
force-pushed
the
ISPN-8719_key_converter
branch
2 times, most recently
from
c0a0115
to
495d8d4
Compare
wburns
force-pushed
the
ISPN-8719_key_converter
branch
3 times, most recently
from
e93b99c
to
ea7bba1
Compare
versions before 9.1 * Added iterator methods to Codecs * Put appropriate methods on each Codec version
wburns
force-pushed
the
ISPN-8719_key_converter
branch
from
ea7bba1
to
bdd05d2
Compare
wburns
changed the title
|
This looks great. We will eventually need some integration tests for testing against combinations of servers/clients. |
versions before 9.2
https://issues.jboss.org/browse/ISPN-8719