ISPN-8982 Hibernate ORM 5.3 2LC implementation #5900
Conversation
| @@ -11,14 +11,23 @@ This chapter focuses on what you need to know to use Infinispan as second-level | |||
| Applications running in environments where Infinispan is not default cache provider for Hibernate will need to depend on the correct cache provider version. | |||
| The Infinispan cache provider version suitable for your application depends on the Hibernate version in use: | |||
|
|
|||
| If using Hibernate 5.2 or higher, the Maven coordinates are the following: | |||
| If using Hibernate 5.3 or higher, the Maven coordinates are the following: | |||
There was a problem hiding this comment.
I guess it should say:
If using Hibernate 5.3, the Maven coordinates are the following:
Once we release higher versions we'll have new -vXX projects?
There was a problem hiding this comment.
Right.
I think that -vXX sets the expectations more clear. I could have moved 5.2 support from main to v52 packages but moving stuff around just because we have a newer version seems wrong to me. This approach should not break users who use FQCN for region factory.
|
Needs rebasing btw |
|
@galderz The intention of the infinispan-hibernate-cache-spi is to decouple the application server 2LC integration from any specific version of Hibernate ORM. |
rvansa
force-pushed
the
ISPN-8982
branch
3 times, most recently
from
9049e00
to
162ddf4
Compare
rvansa
force-pushed
the
ISPN-8982
branch
3 times, most recently
from
abaccb7
to
b74810f
Compare
|
Err, I have changed the way comparator is created for NSRW in v53 but it's wrong - the comparator in |
|
OK, I've backported some of the work from ISPN-9059 to this PR, letting VersionedCallInterceptor to fetch comparator for given type. I am not sure if NSRW access to a collection using structured entries ( |
|
Radim, when could a backport + release, of this change in 9.2.x be ready to include in WF13? I need to ask when it is too late to add a 9.2.x update into WF13, it would be helpful if I have an estimate of when this will be ready. Of course, I will report back with what I hear about when its too late. Thanks! |
|
@scottmarlow We'll address the backport + release with maximum priority. I am just waiting for ORM release to change dependencies to non-snapshot version. Once that's out, I'll update & prepare 9.2 backport. |
* Includes infinispan-hibernate-cache-spi (and related changes) by Paul Ferraro * Regions moved from commons to version-specific modules. * infinispan-hibernate-cache is now merely a copy-paste of v51 with necessary SPI changes, and this module won't be in Infinispan 9.3 * v53 drops support for transactional caches completely.
|
Updated to use ORM CR2 & removed 5.2 compatibility (this is kept in #5946 only). |
|
Thanks @rvansa! Can we integrate it now? Or is there anything else that needs doing? |
|
@galderz There's no more work on this adapting the SPIs, everything is implemented. Improvements and optimizations will come as https://issues.jboss.org/browse/ISPN-9059 and https://issues.jboss.org/browse/ISPN-9075 later. |
https://issues.jboss.org/browse/ISPN-8982
necessary SPI changes, and this module won't be in Infinispan 9.3
This is marked as preview for two reasons:
Despite of these I request review.