ISPN-9002 LocalModeNoPassivationTest.testValuesWithEvictedEntries random #5957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
failures * Fixed issue with retrieval during close
|
This could occur during the following window
|
danberindei
reviewed
May 4, 2018
| @@ -126,7 +132,7 @@ public void processEntry(MarshalledEntry<K, V> marshalledEntry, AdvancedCacheLoa | |||
| closeLock.lock(); | |||
| try { | |||
| // If is possible that someone inserted a value and then acquired the close lock - thus we must recheck | |||
| if (closed || (entry = queue.poll()) != null) { | |||
| if ((entry = queue.poll()) != null || closed) { | |||
There was a problem hiding this comment.
I stared for 5 minutes at this code yesterday without realizing what switching the evaluation order would do...
I saw it when I looked again today, but may I suggest not mixing complex if conditions and assignments? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
failures
https://issues.jboss.org/browse/ISPN-9002