Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-9113 SITE_UNREACHABLE not handled by JGroupsTransport #5958

Merged
merged 3 commits into from May 10, 2018
Merged

ISPN-9113 SITE_UNREACHABLE not handled by JGroupsTransport #5958

merged 3 commits into from May 10, 2018

Conversation

danberindei
Copy link
Member

https://issues.jboss.org/browse/ISPN-9113

  • Implement only UpHandler in ChannelCallbacks
  • Enable BaseLocalClusterTxFailureTest tests

@danberindei danberindei requested a review from galderz May 4, 2018 07:44
@danberindei danberindei force-pushed the ISPN-9113_site_unreachable branch 2 times, most recently from 941a324 to 7a9f899 Compare May 9, 2018 11:12
@danberindei
Copy link
Member Author

TxOfflineTest and NonTxOfflineTest were failing because JGroupsTransport.backupRemotely was ignoring CacheNotFoundResponse and backup RPCs were succeeding even though the remote site was down. I changed it to use a validating response collector and now the tests pass.

@galderz For ISPN-9111 ignoring the unreachable site is probably better, but I'm afraid we'll need deeper changes before we can do that.

@danberindei
ISPN-9113 Enable BaseLocalClusterTxFailureTest tests
a90e785 
TestNG wasn't running testPrepareFailure because it didn't have
a group.
tristantarrant
tristantarrant reviewed May 9, 2018
View reviewed changes
core/src/main/java/org/infinispan/remoting/transport/jgroups/JGroupsTransport.java Outdated
case Event.SITE_UNREACHABLE:
siteUnreachable(evt.getArg());
SiteMaster site_master=evt.getArg();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird spacing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some traces of JGroups in :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did look Bela-ish 😄

@tristantarrant
Copy link
Member

Looks good to me, just one minor cosmetic issue

@tristantarrant tristantarrant added this to the 9.3.0.Beta1 milestone May 9, 2018
@tristantarrant tristantarrant merged commit e6a4f99 into infinispan:master May 10, 2018
@danberindei danberindei deleted the ISPN-9113_site_unreachable branch May 10, 2018 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristantarrant tristantarrant tristantarrant left review comments

@galderz galderz Awaiting requested review from galderz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.3.0.Beta1
2 participants
@danberindei @tristantarrant