ISPN-9259 Fix agent-bond and jolokia module paths #6139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll backport this to 9.3.x as well. |
wburns
reviewed
Jul 13, 2018
| @@ -1,5 +1,5 @@ | |||
| set AGENT_BOND_JAR= | |||
| for /r %JBOSS_HOME%\modules\io\fabric8\agent-bond\main %%X in (*.jar) do ( | |||
| for /r %JBOSS_HOME%modules\system\add-ons\@infinispan.module.slot.prefix@\io\fabric8\agent-bond\@infinispan.module.slot@ %%X in (*.jar) do ( | |||
There was a problem hiding this comment.
Hrmm, can we assume that JBOSS_HOME env variable will always have the separator present?
There was a problem hiding this comment.
Nope, that was removed by mistake
|
Looks good to me (assuming Ryan tested it with Jolokia), I can merge unless anyone else has any last second things they wanted to add. |
|
Integrated into master, thanks @ryanemerson ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-9363