Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-9387 Server-side TCP KeepAlive #6157

Merged

Conversation

tristantarrant
Copy link
Member

@tristantarrant tristantarrant commented Jul 18, 2018

https://issues.jboss.org/browse/ISPN-9387

For naming consistency, I've also made some backwards incompatible API change to the Router endpoint. I don't think this is a problem, but let me know if you think otherwise.

@tristantarrant tristantarrant added this to the 9.4.0.Beta1 milestone Jul 18, 2018
@tristantarrant tristantarrant force-pushed the ISPN-9387/server_tcp_keepalive branch 3 times, most recently from 1e5d223 to a229999 Compare July 19, 2018 13:04
.setAllowExpression(true)
.setXmlName(ModelKeys.TCP_KEEPALIVE)
.setRestartAllServices()
.setDefaultValue(new ModelNode().set(true))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the default false?

@pruivo pruivo added the Question label Aug 2, 2018
@pruivo pruivo merged commit 33d62db into infinispan:master Aug 3, 2018
@pruivo
Copy link
Member

pruivo commented Aug 3, 2018

integrated!
@tristantarrant check my comment for CR1. I've run the tests locally and they are fine.
thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants