Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-1506 Retrieve host and port from the typed properties #617

Closed
wants to merge 1 commit into from
Closed

ISPN-1506 Retrieve host and port from the typed properties #617

wants to merge 1 commit into from

Conversation

galderz
Copy link
Member

@galderz galderz commented Nov 7, 2011

@Sanne
Copy link
Member

Sanne commented Nov 7, 2011

merged

@Sanne Sanne closed this Nov 7, 2011
Sanne
Sanne reviewed Nov 7, 2011
View reviewed changes
server/hotrod/src/main/scala/org/infinispan/server/hotrod/HotRodServer.scala
val externalHost = typedProps.getProperty(PROP_KEY_PROXY_HOST,
typedProps.getProperty(PROP_KEY_HOST, HOST_DEFAULT, true))
val externalPort = typedProps.getIntProperty(PROP_KEY_PROXY_PORT,
typedProps.getIntProperty(PROP_KEY_PORT, defaultPort, true))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems defaultPort could use full capitals, and defien the "11222" value as a constant (like you did for others like HOST_DEFAULT)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@galderz @Sanne