ISPN-9485 RoundRobinBalancingStrategy always starts from server 0 #6236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,7 +29,7 @@ public void setServers(Collection<SocketAddress> servers) { | |||
| this.servers = servers.toArray(new SocketAddress[servers.size()]); | |||
| // keep the old index if possible so that we don't produce more requests for the first server | |||
| if (index >= this.servers.length) { | |||
| index = 0; | |||
| index = ThreadLocalRandom.current().nextInt(this.servers.length); | |||
There was a problem hiding this comment.
Shouldn't index be initialized to MAX_INT in order to trigger this on 1st call ?
There was a problem hiding this comment.
Oops, I meant to remove the if
danberindei
force-pushed
the
ISPN-9485_round_robin
branch
from
e6f2ef6
to
008e951
Compare
|
Updated to remove the if and to fix the test |
danberindei
force-pushed
the
ISPN-9485_round_robin
branch
from
008e951
to
dc527f1
Compare
danberindei
force-pushed
the
ISPN-9485_round_robin
branch
from
dc527f1
to
2216699
Compare
|
Integrated into master, thanks @danberindei ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-9485