Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-9511 Expired event is not raised when modifying an expired entry #6375

Merged
merged 1 commit into from Nov 7, 2018
Merged

ISPN-9511 Expired event is not raised when modifying an expired entry #6375

merged 1 commit into from Nov 7, 2018

Conversation

gustavolira
Copy link
Contributor

@wburns
Copy link
Member

wburns commented Nov 7, 2018 •
edited

Test looks good @gustavolira, thanks!

If you could tweak the commit message to be in the format, then I will integrate it.

ISPN-XXXX <JIRA Desc>

 * <notes>
 * <additional notes>

wburns
wburns requested changes Nov 7, 2018
View reviewed changes
Copy link
Member

@wburns wburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to update the commit message, otherwise good job! 👍

@danberindei
Copy link
Member

@wburns actually there should be an empty line between the ISPN-XXXX line and the body ;)

@wburns
Copy link
Member

wburns commented Nov 7, 2018

@danberindei fixed it :)

@gustavolira gustavolira changed the title Adding reproducer for ISPN-9511 ISPN-9511 Expired event is not raised when modifying an expired entry Nov 7, 2018
@wburns wburns merged commit 68fd720 into infinispan:master Nov 7, 2018
@wburns
Copy link
Member

wburns commented Nov 7, 2018

Integrated into master, thanks @gustavolira !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wburns wburns wburns requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@gustavolira @wburns @danberindei