ISPN-1525: Different transactions using same dummy XIDs #646
Conversation
| Random rnd = new Random(); | ||
| rnd.nextBytes(globalTransactionId); | ||
| rnd.nextBytes(branchQualifier); | ||
| initialize(globalTransactionId); |
There was a problem hiding this comment.
Manik, a UUID is 128 bits, and globalTransactionId is 64 and branchQualifier is 64. Wouldn't it be easier to create a single UUID and give the first 64 bits to the global transaction id and the other 64 bits to the branch qualifier?
The way you have it now, you're not taking full advantage of the 128 bits (you're taking only 64 bits of a UUID and giving it to a one of the instance variables) and so this leaves a gap, albeit small, for duplicates, doesn't it?
There was a problem hiding this comment.
No, I use a separate UUID for globalTransactionId and a separate one for branchQualifier.
UUIDs are 128 bits and the XID components are 64 bytes each. :)
There was a problem hiding this comment.
Ups, my bad.
Btw, just remembered the pain of debugging this. We really need hex representation for byte[].
Quickly hacked this: https://gist.github.com/1370843 - creating a separate jira....
https://issues.jboss.org/browse/ISPN-1525