ISPN-1529 Remove the autoCommit getter and change variable to Boolean #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, this ain't finished... hold off... |
|
We're lacking testing overriding of default values with configurations read from XML. Sure, this is going away but I've found a bug with my original solution for this which wasn't caught by XmlFileParsingTest. I'll fix it asap... |
|
This should be ready now. |
| @@ -1696,8 +1696,7 @@ public class Configuration extends AbstractNamedCacheConfigurationBean { | |||
| protected TransactionMode transactionMode = TransactionMode.NON_TRANSACTIONAL; | |||
|
|
|||
| @ConfigurationDocRef(bean = Configuration.class, targetElement = "isTransactionAutoCommit") | |||
There was a problem hiding this comment.
Shouldn't targetElement be "isAutoCommit"?
There was a problem hiding this comment.
It's right as it is.
There was a problem hiding this comment.
Of course Galder, I missed the bean = Configuration.class part :)
* First, Remove the autoCommit getter and change variable to Boolean. The schema generator was getting confused and assuming that the XML attribute should be derived from the getter. That was cos the instance variable was using boolean instead of Boolean. * Secondly, autoCommit will only be detected if marked as overriden. Apart from fixing this by creating a setter, transform XML file parsing test in order to test overrides for named cache configuration tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-1529
The schema generator was getting confused and assuming that the XML attribute should be derived from the getter. That was cos the instance variable was using boolean instead of Boolean.