invoke NotifyingNotifiableFuture#notifyDone from non-calling thread #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| return result; | ||
| } | ||
| }; | ||
| l.setNetworkFuture(asyncExecutor.submit(c)); | ||
| futureSet.countDown(); | ||
| futureSet.countDown(); | ||
| l.notifyDone(); |
There was a problem hiding this comment.
The point of the method is to make the RPC asynchronously, so I'm pretty sure in most cases invokeRemotelyInFuture returns before invokeRemotely returns (on the background thread).
There was a problem hiding this comment.
See UT on how we can not notifyDone from the same thread invoking invokeRemotely
|
Vladimir, JIRA? |
|
https://issues.jboss.org/browse/ISPN-1541 will append more description soon |
|
Integrated, we did come to an agreement in the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master only. Do not integrate yet, as we have no consensus about resolution! See https://issues.jboss.org/browse/ISPN-1541