ISPN-9863 Fix leak-related random failures #6724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danberindei
force-pushed
the
ISPN-9863_redo
branch
4 times, most recently
from
1f10542
to
7fc06a1
Compare
danberindei
changed the title
|
Ready for review, random failures in JCacheConfigurationTest are caused by https://issues.jboss.org/browse/ISPN-9917 |
danberindei
force-pushed
the
ISPN-9863_redo
branch
2 times, most recently
from
7cfbb54
to
310f156
Compare
* Move leak detection to a @AfterSuite configuration method. That way leak detection works even if the last test does not extend AbstractInfinispanTest. * Also move detection of wrong/missing groups or testName to a @BeforeSuite method + fix LimitExpiryFactoryTest. * TestNG modules run ThreadLeakCheckTest from commons-test. * JUnit modules check for thread leaks in JUnitTestListener and/or TestResourceTrackingListener. * JUnitTestListener.testRunFinished failures still build, so tests that may leak threads should use TestResourceTrackingListener.
danberindei
force-pushed
the
ISPN-9863_redo
branch
from
310f156
to
4218be3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for ISPN-9863 because it wasn't always catching leaks in the spring5 modules, depending on whether the last test to run called
TestResourceTrackeror not.from the commons-test module
or in JUnitTestListener