ISPN-9422 Remove Worker Threads property #6773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tristantarrant There are a few related test failures |
|
@tristantarrant What's up with this? |
|
It looks like the |
tristantarrant
force-pushed
the
ISPN-9422/remove_workerthreads_props
branch
from
ef3a761
to
069f140
Compare
tristantarrant
force-pushed
the
ISPN-9422/remove_workerthreads_props
branch
from
069f140
to
9916b7d
Compare
|
Failures are unrelated |
danberindei
reviewed
Jun 4, 2019
| public static final AttributeDefinition<AdminOperationsHandler> ADMIN_OPERATION_HANDLER = AttributeDefinition.builder("admin-operation-handler", null, AdminOperationsHandler.class).immutable().build(); | ||
| public static final AttributeDefinition<Boolean> ZERO_CAPACITY_NODE = AttributeDefinition.builder("zero-capacity-node", false).immutable().build(); | ||
|
|
||
| // The default value can be overridden so it is the responsibility of each protocol to add it to the set | ||
| public static final AttributeDefinition<Integer> WORKER_THREADS = AttributeDefinition.builder("worker-threads", 1).immutable().build(); |
There was a problem hiding this comment.
Should we keep the attribute definition in the base class at all? It's not very clear why the Memcached and REST servers should have only 1 worker thread, if each had its own definition it could also have a comment explaining the choice.
- Also ensure that different default worker thread defaults don't pollute the others
tristantarrant
force-pushed
the
ISPN-9422/remove_workerthreads_props
branch
from
9916b7d
to
6d207f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/ISPN-9422
I've also made sure that different endpoints can actually have different defaults