Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-10204 Add 'java.se' module to server integration testsuite #6896

Closed

Conversation

ryanemerson
Copy link
Contributor

@ryanemerson ryanemerson commented May 7, 2019

https://issues.jboss.org/browse/ISPN-10204

Prevents ModuleNotFoundException: java.se when executing the server testsuite. This does not seem to occur on the CI, but always happens on my local machine. Issuing a PR to see what happens on CI with the changes.

@ghost
Copy link

ghost commented May 7, 2019

Can one of the admins verify this patch?

@ryanemerson
Copy link
Contributor Author

@tristantarrant Is this my punishment for breaking the release?

Copy link
Member

@galderz galderz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing JIRA.

@tristantarrant
Copy link
Member

Still I don't understand why you need this when the build is working everywhere else

@galderz
Copy link
Member

galderz commented May 20, 2019

@ryanemerson What JDK are you using? Did you try others?

@galderz
Copy link
Member

galderz commented May 20, 2019

@tristantarrant I'm not so worried about the change, there are some reports out there of similar errors and this is just a test change.

@ryanemerson
Copy link
Contributor Author

@galderz

openjdk version "11.0.3" 2019-04-16
OpenJDK Runtime Environment 18.9 (build 11.0.3+7)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.3+7, mixed mode, sharing)

OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T20:00:29+01:00)
Maven home: /opt/apache-maven-3.6.1
Java version: 11.0.3, vendor: Oracle Corporation, runtime: /usr/lib/jvm/java-11-openjdk-11.0.3.7-1.fc28.x86_64
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "5.0.13-100.fc28.x86_64", arch: "amd64", family: "unix"

Still I don't understand why you need this when the build is working everywhere else

@tristantarrant I have no idea tbh, I gave up looking as it was preventing me working on other things and this workaround works. Atm I just have to cherry-pick this commit into my working branch if I need to run the server integration tests 😢

@ryanemerson ryanemerson changed the title Add 'java.se' module to server integration testsuite ISPN-10204 Add 'java.se' module to server integration testsuite May 20, 2019
@wburns
Copy link
Member

wburns commented Jun 13, 2019

Closing for now as this seems like a possible env issue. Can be reopened later if needed.

@wburns wburns closed this Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants